8000
Skip to content

Remove AlwaysNullReadOnlyVariableDetector from SlackIssueRegistry#410

Merged
ZacSweers merged 1 commit intomainfrom
yfw-remove-null-detector
Jul 17, 2025
Merged

Remove AlwaysNullReadOnlyVariableDetector from SlackIssueRegistry#410
ZacSweers merged 1 commit intomainfrom
yfw-remove-null-detector

Conversation

@ywu96
Copy link
Copy Markdown
Collaborator
@ywu96 ywu96 commented Jul 17, 2025

Summary

We've narrowed down the cause of #400 to AlwaysNullReadOnlyVariableDetector. We're not entirely sure why this detector is causing the error, but we're going to disable it temporarily to allow the other detectors to be updated as we investigate it further.

Fixes #400

Requirements (place an x in each [ ])

The following point can be removed after setting up CI (such as Travis) with coverage reports (such as Codecov)

  • I've written tests to cover the new code and functionality included in this PR.

The following point can be removed after setting up a CLA reporting tool such as cla-assistant.io

@ZacSweers ZacSweers added this pull request to the merge queue Jul 17, 2025
@ZacSweers ZacSweers removed this pull request from the merge queue due to a manual request Jul 17, 2025
@ZacSweers ZacSweers merged commit bcbbb8b into main Jul 17, 2025
3 checks passed
@ZacSweers ZacSweers deleted the yfw-remove-null-detector branch July 17, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 0.10.0 crashes with "You must override visitCallExpression (and don't call super.visitCallExpression!)"

2 participants

0