8000
Skip to content

Added gradio Image Stitching demo link#1871

Merged
edgarriba merged 3 commits intokornia:masterfrom
kadirnar:Image_Stitching_Readme
Sep 12, 2022
Merged

Added gradio Image Stitching demo link#1871
edgarriba merged 3 commits intokornia:masterfrom
kadirnar:Image_Stitching_Readme

Conversation

@kadirnar
Copy link
Copy Markdown
Contributor
@kadirnar kadirnar commented Sep 8, 2022

Changes

  • Added Hugging Face demo.

Fixed #53 (comment)

Type of change

  • 📚 Documentation Update
  • 🧪 Tests Cases
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔬 New feature (non-breaking change which adds functionality)
  • 🚨 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Did you update CHANGELOG in case of a major change?

@NimaBoscarino
Copy link
Copy Markdown
Contributor
NimaBoscarino commented Sep 8, 2022

This is awesome! Could you also embed the demo into the docs? You'll need to:

  1. Make a new file called something like stitching_gradio.html under here: https://github.com/kornia/kornia/tree/master/docs/source/gradio
  2. Fill that file with the following:
<script type="module" src="https://gradio.s3-us-west-2.amazonaws.com/3.1.7/gradio.js"></script>
<gradio-app space="kornia/Image-Stitching"></gradio-app>
  1. Embed it in the image_stitching.rst file with this:
.. raw:: html
    :file: gradio/stitching_gradio.html

That should embed it like the one on this page: https://kornia.readthedocs.io/en/latest/enhance.html

@edgarriba edgarriba changed the title Added Hugging Face demo link. Added gradio Image Stitching demo link Sep 12, 2022
@edgarriba edgarriba merged commit bbd39ec into kornia:master Sep 12, 2022
@edgarriba
Copy link
Copy Markdown
Member
edgarriba commented Sep 13, 2022

@kadirnar @NimaBoscarino for some reason is not showing up the whole thing

https://kornia.readthedocs.io/en/latest/applications/image_stitching.html

@kadirnar kadirnar deleted the Image_Stitching_Readme branch September 13, 2022 15:05
@kadirnar
Copy link
Copy Markdown
Contributor Author
kadirnar commented Sep 14, 2022

Hello @edgarriba ,

What is wrong? I didn't understand. I will send a PR request for module "fit_line". Is there something missing in this PR?

@NimaBoscarino
Copy link
Copy Markdown
Contributor
NimaBoscarino commented Sep 14, 2022

It's just a path issue in the way the file was embedded, i.e. gradio/stitching_gradio.html where it should be ../gradio/stitching_gradio.html. I can fix it with a PR tomorrow where I'll adjust any other demos that aren't rendering properly.

@edgarriba
Copy link
Copy Markdown
Member
edgarriba commented Sep 16, 2022

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edgarriba edgarriba edgarriba approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[COMMUNITY] Call for contributions / tutorials / examples

3 participants

@kadirnar @NimaBoscarino @edgarriba
0