Macos compile errors and warnings #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmed256
reviewed
Apr 10, 2020
Member
There was a problem hiding this comment.
Thanks for finding these compilation issues and making a PR to fix them!
We might want to fix the C++11 warning by updating the compilation flags instead. Do you have time to update the fix? If not, I'm ok with merging the PR and fixing later.
include/occa/core/base.hpp
Outdated
| const void *src = NULL, | ||
| const occa::properties &props = occa::properties()); | ||
|
|
||
| #pragma clang diagnostic push |
Member
There was a problem hiding this comment.
Oh, maybe we're missing the proper C++11 flags when compiling the files
-std=c++11 -stdlib=libc++
| int getTID() { | ||
| #if (OCCA_OS & (OCCA_LINUX_OS | OCCA_MACOS_OS)) | ||
| return syscall(SYS_gettid); | ||
| #if OCCA_OS == OCCA_MACOS_OS & (MAC_OS_X_VERSION_MAX_ALLOWED >= MAC_OS_X_VERSION_10_12) |
Member
There was a problem hiding this comment.
🔥 awesome, thanks for filing + fixing this warning!
added 2 commits
April 11, 2020 07:40
Require C++11 or greater.
Use target_compile_options to suppress the following warnings:
* default template arguments for a function template are a C++11 extension [-Wc++11-extensions]
* unused parameter 'XXX' [-Wunused-parameter]
This reverts commit feac737.
Contributor
Author
|
I've removed the pragmas, and instead used target_compile_features and target_compile_options to customise warning reporting. |
Member
|
Looks good, thank you for making the changes so fast! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cmake build on macOS 10.14.6 failed with:
This has been resolved by using mach_timebase_info_data_t instead.
A number of warnings were also emitted relating to C++11 extensions, e.g.
These have been silenced using pragmas.
Two deprecated functions, AbsoluteToNanoseconds and syscall, have been factored out: