Make build system understand new hipconfig output #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From ROCm 4.0, hipconfig --platform will output 'amd' instead of 'hcc'. This change simply proactively mitigates a potential surprise where OCCA thinks it couldn't find ROCm.
Codecov Report
@@ Coverage Diff @@
## main #421 +/- ##
=======================================
Coverage 76.29% 76.29%
=======================================
Files 241 241
Lines 18817 18817
=======================================
Hits 14356 14356
Misses 4461 4461 |
noelchalmers
added a commit
to noelchalmers/occa
that referenced
this pull request
Nov 20, 2020
dmed256
pushed a commit
that referenced
this pull request
Nov 21, 2020
noelchalmers
pushed a commit
to noelchalmers/occa
that referenced
this pull request
Dec 3, 2020
From ROCm 4.0, hipconfig --platform will output 'amd' instead of 'hcc'. This change simply proactively mitigates a potential surprise where OCCA thinks it couldn't find ROCm.
noelchalmers
added a commit
to noelchalmers/occa
that referenced
this pull request
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ROCm 4.0, hipconfig --platform will output 'amd' instead of 'hcc'.
This change simply proactively mitigates a potential surprise where OCCA
thinks it couldn't find ROCm.
Description