[Core] Zero size memory quick returns #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hey are zero size allocations
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #678 +/- ##
===============================================
- Coverage 76.23% 76.22% -0.01%
===============================================
Files 291 291
Lines 18798 18795 -3
===============================================
- Hits 14330 14326 -4
- Misses 4468 4469 +1
|
Member
|
Since these changes were included in nekRS after this PR was opened, I am going to assume that this solution works for them. |
kris-rowe
pushed a commit
that referenced
this pull request
Sep 12, 2023
…hey are zero size allocations (#678)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let some memory methods return quickly instead of error when they are zero size allocations.
Addresses #648, but in a different manner than PR #649.
@MalachiTimothyPhillips can you weight in if this would solve your issue?