fix(sdk): disclose per-line clipping in large-result previews - #5564
Open
Mason Daugherty (mdrxy) wants to merge 1 commit into
Open
fix(sdk): disclose per-line clipping in large-result previews#5564Mason Daugherty (mdrxy) wants to merge 1 commit into
Mason Daugherty (mdrxy) wants to merge 1 commit into
Conversation
Mason Daugherty (mdrxy)
force-pushed
the
mdrxy/sdk/preview-note-clipped-lines
branch
from
August 19, 2026 22:32
80e57ca to
d60d6ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5563.
When a previewed line exceeds the per-line character budget, the preview silently showed only its leading characters — presenting an excerpt as the whole result. Previews now add a disclosure when any displayed line is clipped, alongside (and independently of) the omitted-middle-lines marker explanation.
_create_content_previewclips each shown line toPREVIEW_LINE_CHAR_LIMITand records whether any line was actually cut, surfacing it as a secondContentPreviewflag alongsidelines_omitted. The two flags track independent kinds of loss — a preview can omit middle lines, clip long displayed lines, both, or neither — so_preview_notereports each only when it occurred. A line exactly at the limit is not reported as clipped.The capture-offload path in
FilesystemMiddlewarehas no per-line budget (its losses are byte-based and disclosed in-band), so it passeslines_clipped=Falseexplicitly rather than leaving the flag to be inferred.