8000
Skip to content

Upgrades fmtlib to v8.0.1#2809

Merged
akohlmey merged 7 commits intolammps:developfrom
rbberger:fmt_upgrade
Dec 13, 2021
Merged

Upgrades fmtlib to v8.0.1#2809
akohlmey merged 7 commits intolammps:developfrom
rbberger:fmt_upgrade

Conversation

@rbberger
Copy link
Copy Markdown
Member
@rbberger rbberger commented Jun 21, 2021 •
edited by akohlmey
Loading

Summary

This PR upgrades the included fmtlib files to v8.0.1

Author(s)

Richard Berger and Axel Kohlmeyer, Temple U

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

N/A

Implementation Notes

We have a few custom patches in fmtlib that had to be reapplied afterward. Does not include the src/fmt.cc file, which is a C++20 module.

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.

Further Information, Files, and Links

https://github.com/fmtlib/fmt/releases/tag/8.0.1

@akohlmey
Copy link
Copy Markdown
Member
akohlmey commented Jun 24, 2021

FYI, looks like version 8.0.0 changes the behavior for formatting floating point numbers with {:.8}. With version 7.x it would always print 8 digits output and thus have more "even" output. Now it is skipping over trailing zeroes, which is what caused the mismatch in the unit tests.

@akohlmey akohlmey changed the title Upgrades fmtlib to v8.0.0 Upgrades fmtlib to v8.0.1 Oct 10, 2021
@akohlmey akohlmey changed the base branch from master to develop October 12, 2021 18:07
@akohlmey akohlmey added the ppc64le Add ppc64le build label Oct 19, 2021
@akohlmey
Copy link
Copy Markdown
Member
akohlmey commented Oct 20, 2021

@rbberger I just checked the differences between this PR and upstream and it seems that the change in fmtlib/fmt#2555 is the only customization versus upstream we require to have LAMMPS compiled on all platforms in use.

@akohlmey akohlmey self-assigned this Dec 11, 2021
@akohlmey akohlmey added test_for_regression Enable to trigger regression tests test_runs Enable to trigger run tests labels Dec 11, 2021
@akohlmey akohlmey self-requested a review December 11, 2021 04:08
@akohlmey akohlmey removed test_runs Enable to trigger run tests test_for_regression Enable to trigger regression tests ppc64le Add ppc64le build labels Dec 11, 2021
@akohlmey
Copy link
Copy Markdown
Member
akohlmey commented Dec 11, 2021

@rbberger should we merge this now? It doesn't look like there will be a a version 8.0.2 and all compilation issues plus the unit test failures seem to be resolved.

@akohlmey akohlmey mentioned this pull request Dec 13, 2021
Merged
11 tasks
@rbberger rbberger marked this pull request as ready for review December 13, 2021 15:02
@rbberger rbberger added ppc64le Add ppc64le build and removed ppc64le Add ppc64le build labels Dec 13, 2021
@rbberger
Copy link
Copy Markdown
Member Author
rbberger commented Dec 13, 2021

@akohlmey LGTM

@akohlmey akohlmey requested a review from sjplimp December 13, 2021 16:58
@akohlmey akohlmey merged commit 1e73bec into lammps:develop Dec 13, 2021
@akohlmey akohlmey deleted the fmt_upgrade branch December 13, 2021 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjplimp sjplimp sjplimp approved these changes

@akohlmey akohlmey Awaiting requested review from akohlmey akohlmey is a code owner

Assignees

@akohlmey akohlmey

Labels

maintenance ready_for_merge update

Projects

None yet

Milestone

Stable Release Summer 2022

Development

Successfully merging this pull request may close these issues.

3 participants

@rbberger @akohlmey @sjplimp
0