teunbrand · 2024-12-17T08:07:29Z

This PR aims to fix #6243.

Briefly, missing values are thrown out and warn about when na.rm = FALSE.
The warning is skipped when na.rm = TRUE but missing values are thrown out.
When throwing out missing values, the group aesthetic is reformed so that groups with NA values break up into new uninterrupted groups.

Reprex from issue, note gradient is uniform now:

devtools::load_all("~/packages/ggplot2/")
#> ℹ Loading ggplot2

df <- data.frame(
  x = c(1:3, 1:3),
  ymin = c(1, 1, 1, NA, 2, 2),
  ymax = c(1.5, 2, 1.5, 2.5, 3, 2.5),
  group = c(1,1,1,2,2,2)
)

ggplot(df, aes(x, ymin = ymin, ymax = ymax, group = group, fill = x)) +
  geom_ribbon() +
  scale_fill_viridis_c()
#> Warning: Removed 1 row containing missing values or values outside the scale range
#> (`geom_ribbon()`).

^{Created on 2024-12-17 with reprex v2.1.1}

thomasp85

LGTM

teunbrand added 3 commits December 17, 2024 09:00

custom GeomRibbon$handle_na method

90f60eb

modify test

cf40e19

add news bullet

40d072a

thomasp85 approved these changes Dec 17, 2024

View reviewed changes

teunbrand merged commit efc53cc into tidyverse:main Dec 17, 2024

teunbrand deleted the geom_ribbon_narm branch December 17, 2024 11:00

teunbrand mentioned this pull request Feb 19, 2025

New warning missing values or values outside the scale range with geom_area(position = position_fill()) #6338

Closed

teunbrand mentioned this pull request Oct 2, 2025

Warnings with geom_area() with axis limits corresponding to min/max values being plotted introduced by ggplot2 v4.0.0 #6667

Closed

Navigation Menu

Uh oh!

Fix `geom_ribbon(na.rm)` - #6244