bdraco · 2026-01-04T22:07:15Z

What does this implement/fix?

Combine consecutive log statements into single calls using multi-line string literals.

Logging is one of the most intensive operations in ESPHome and blocks the event loop longer than most other operations. Each ESP_LOG* call involves formatting, memory allocation, serial output, and network packet transmission. Combining consecutive log statements reduces event loop blocking and the number of network packets sent to connected clients.

Note: The log processor reformats multi-line output so each line gets its own timestamp and log level prefix - the final output format is unchanged. Minor reordering of dump_config output may occur when LOG_PIN or other logging macros cannot be combined with ESP_LOG* calls - this is acceptable as it does not affect functionality.

See https://developers.esphome.io/architecture/logging/ for more details.

Types of changes

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Developer breaking change (an API change that could break external components)
Code quality improvements to existing code or addition of tests
Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

Test Environment

Example entry for `config.yaml`:

# N/A - no config changes

Checklist:

The code change is tested and works locally.
Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in esphome-docs.

codecov-commenter · 2026-01-04T22:16:17Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.42%. Comparing base (05695af) to head (84884cc).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev   #12936      +/-   ##
==========================================
- Coverage   73.44%   73.42%   -0.03%     
==========================================
  Files          53       53              
  Lines       11303    11303              
  Branches     1534     1534              
==========================================
- Hits         8302     8299       -3     
- Misses       2602     2604       +2     
- Partials      399      400       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

github-actions · 2026-01-04T22:20:17Z

👋 Hi there! This PR modifies 1 file(s) with codeowners.

@medusalix - As codeowner(s) of the affected files, your review would be appreciated! 🙏

Note: Automatic review request may have failed, but you're still welcome to review.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

github-actions · 2026-01-04T22:28:19Z

To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file:

external_components:
  - source: github://pr#12936
    components: [xiaomi_xmwsdj04mmc]
    refresh: 1h

(Added by the PR bot)

github-actions · 2026-01-04T22:42:43Z

Memory Impact Analysis

Components: xiaomi_xmwsdj04mmc
Platform: esp32-idf

Metric	Target Branch	This PR	Change
RAM	39,172 bytes	39,172 bytes	➡️ +0 bytes (0.00%)
Flash	731,051 bytes	731,051 bytes	➡️ +0 bytes (0.00%)

📊 Component Memory Breakdown

Component	Target Flash	PR Flash	Change
`[esphome]xiaomi_xmwsdj04mmc`	538 bytes	526 bytes	📉 ✅ -12 bytes (-2.23%)

🔍 Symbol-Level Changes (click to expand)

Changed Symbols

Symbol	Target Size	PR Size	Change
`esphome::xiaomi_xmwsdj04mmc::XiaomiXMWSDJ04MMC::dump_config()`	90 bytes	78 bytes	📉 -12 bytes (-13.33%)

Note: This analysis measures static RAM and Flash usage only (compile-time allocation).
Dynamic memory (heap) cannot be measured automatically.
⚠️ You must test this PR on a real device to measure free heap and ensure no runtime memory issues.

This analysis runs automatically when components change. Memory usage is measured from a representative test configuration.

bdraco · 2026-01-04T23:02:50Z

thanks

[xiaomi_xmwsdj04mmc] Combine log statements to reduce loop blocking

84884cc

Copilot AI review requested due to automatic review settings January 4, 2026 22:07

Copilot AI reviewed Jan 4, 2026

swoboda1337 approved these changes Jan 4, 2026

View reviewed changes

Copilot started reviewing on behalf of bdraco January 4, 2026 22:29 View session

esphome Bot added code-quality component: xiaomi_xmwsdj04mmc small-pr PR < 30 lines labels Jan 4, 2026

bdraco merged commit 9d9f9c3 into dev Jan 4, 2026
42 checks passed

bdraco deleted the combine-logs-xiaomi_xmwsdj04mmc branch January 4, 202 8000 6 23:02

github-actions Bot locked and limited conversation to collaborators Jan 6, 2026

Navigation Menu

Uh oh!

Uh oh!

[xiaomi_xmwsdj04mmc] Combine log statements to reduce loop blocking - #12936