[esp32_hosted] Combine log statements to reduce loop blocking - #12884
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #12884 +/- ##
=======================================
Coverage 73.42% 73.42%
=======================================
Files 53 53
Lines 11303 11303
Branches 1534 1534
=======================================
Hits 8299 8299
Misses 2604 2604
Partials 400 400 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
👋 Hi there! I've automatically requested reviews from codeowners based on the files changed in this PR. @swoboda1337 - You've been requested to review this PR as codeowner(s) of 1 file(s) that were modified. Thanks for your time! 🙏 |
Contributor
|
To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file: external_components:
- source: github://pr#12884
components: [esp32_hosted]
refresh: 1h(Added by the PR bot) |
swoboda1337
approved these changes
Jan 4, 2026
Member
Author
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Combine consecutive log statements into single calls using multi-line string literals.
Logging is one of the most intensive operations in ESPHome and blocks the event loop longer than most other operations. Each
ESP_LOG*call involves formatting, memory allocation, serial output, and network packet transmission. Combining consecutive log statements reduces event loop blocking and the number of network packets sent to connected clients.Note: The log processor reformats multi-line output so each line gets its own timestamp and log level prefix - the final output format is unchanged. Minor reordering of dump_config output may occur when LOG_PIN or other logging macros cannot be combined with ESP_LOG* calls - this is acceptable as it does not affect functionality.
See https://developers.esphome.io/architecture/logging/ for more details.
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# N/A - no config changesChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: