8000
Skip to content

[nrf52] add dfu - #9319

Merged
jesserockz merged 32 commits into
esphome:devfrom
tomaszduda23:dfu
Aug 31, 2025
Merged

[nrf52] add dfu#9319
jesserockz merged 32 commits into
esphome:devfrom
tomaszduda23:dfu

Conversation

@tomaszduda23
@tomaszduda23 tomaszduda23 commented Jul 4, 2025 •
edited by jesserockz
Loading
Copy link
Copy Markdown
Contributor

What does this implement/fix?

It allows to enter dfu without using reset pin.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

  • fixes

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@probot-esphome
probot-esphome Bot commented Jul 4, 2025
Copy link
Copy Markdown

Hey there @tomaszduda23,
Thanks for submitting this pull request! Can you add yourself as a codeowner for this integration? This way we can notify you if a bug report for this integration is reported.
In __init__.py of the integration, please add:

CODEOWNERS = ["@tomaszduda23"]

And run script/build_codeowners.py

(message by NeedsCodeownersLabel)

@codecov-commenter
codecov-commenter commented Jul 4, 2025 •
edited
Loading
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.46%. Comparing base (983b3cb) to head (da1300e).

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev    #9319   +/-   ##
=======================================
  Coverage   60.46%   60.46%           
=======================================
  Files          51       51           
  Lines       10422    10422           
  Branches     1390     1390           
=======================================
  Hits         6302     6302           
  Misses       3762     3762           
  Partials      358      358

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomaszduda23 tomaszduda23 mentioned this pull request Jul 4, 2025
Merged
15 tasks
@tomaszduda23 tomaszduda23 mentioned this pull request Jul 17, 2025
Merged
3 tasks
@github-actions
github-actions Bot commented Jul 17, 2025 •
edited
Loading
Copy link
Copy Markdown
Contributor

To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file:

external_components:
  - source: github://pr#9319
    components: [nrf52]
    refresh: 1h

(Added by the PR bot)

@esphome esphome Bot removed the needs-docs label Jul 17, 2025
jesserockz
jesserockz requested changes Jul 17, 2025
View reviewed changes
@jesserockz jesserockz left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this should be built directly into either the zephyr or nrf52 component...

@esphome
esphome Bot marked this pull request as draft July 17, 2025 23:40
@esphome
esphome Bot commented Jul 17, 2025
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@jesserockz
jesserockz requested a review from a team as a code owner August 1, 2025 05:12
jesserockz
jesserockz reviewed Aug 10, 2025
View reviewed changes
Comment thread esphome/components/nrf52/__init__.py Outdated
@github-actions
github-actions Bot commented Aug 11, 2025
Copy link
Copy Markdown
Contributor

👋 Hi there! This PR modifies 6 file(s) with codeowners.

@esphome/core - As codeowner(s) of the affected files, your review would be appreciated! 🙏

Note: Automatic review request may have failed, but you're still welcome to review.

@jesserockz jesserockz mentioned this pull request Aug 12, 2025
Merged
15 tasks
@jesserockz
jesserockz merged commit 905e290 into esphome:dev Aug 31, 2025
25 checks passed
@bdraco
bdraco commented Sep 1, 2025
Copy link
Copy Markdown
Member

./script/test_build_components -e config -c adc -t nrf52-mcumgr fails with this commit

@bdraco bdraco mentioned this pull request Sep 1, 2025
Merged
14 tasks
@tomaszduda23 tomaszduda23 mentioned this pull request Sep 1, 2025
Merged
15 tasks
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees

No one assigned

Labels

by-code-owner component: nrf52 core has-tests new-feature platform: nrf52

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tomaszduda23 @codecov-commenter @bdraco @jesserockz
0