8000
Skip to content

fix HTTP Request reusing connections with different hosts - #1383

Merged
jesserockz merged 1 commit into
esphome:devfrom
Anonym-tsk:http_request_reuse_fix
Dec 3, 2020
Merged

fix HTTP Request reusing connections with different hosts#1383
jesserockz merged 1 commit into
esphome:devfrom
Anonym-tsk:http_request_reuse_fix

Conversation

@Anonym-tsk
@Anonym-tsk Anonym-tsk commented Nov 19, 2020
Copy link
Copy Markdown
Contributor

Description:

Don't reuse connection if URL has been changed

Related issue (if applicable):
closes #1374
fixes esphome/issues#1232

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@glmnet glmnet changed the title HTTP Request fix reusing connections fix HTTP Request reusing connections Nov 20, 2020
@glmnet glmnet changed the title fix HTTP Request reusing connections fix HTTP Request reusing connections with different hosts Nov 20, 2020
@glmnet glmnet left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesserockz
jesserockz merged commit c12c9e9 into esphome:dev Dec 3, 2020
This was referenced Feb 3, 2021
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

http_request post always sends the same url

3 participants

0