Add additional test coverage ahead of Path conversion - #10700
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #10700 +/- ##
==========================================
+ Coverage 65.89% 67.52% +1.62%
==========================================
Files 52 52
Lines 10560 10560
Branches 1416 1416
==========================================
+ Hits 6959 7131 +172
+ Misses 3220 3050 -170
+ Partials 381 379 -2 ☔ View full report in Codecov by Se
8000
ntry. 🚀 New features to boost your workflow:
|
bdraco
marked this pull request as ready for review
September 13, 2025 19:34
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds comprehensive test coverage for core ESPHome functionality in preparation for Path conversion work, expanding tests for storage JSON, PlatformIO API, and core configuration modules.
- Adds extensive tests for StorageJSON and EsphomeStorageJSON serialization, deserialization, and file operations
- Introduces comprehensive PlatformIO API test coverage including idedata caching, stacktrace processing, and build functionality
- Expands core configuration tests with hostname validation, build path handling, and platform detection
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/unit_tests/test_storage_json.py | Adds 300+ lines of tests covering StorageJSON and EsphomeStorageJSON classes with serialization, loading, and equality testing |
| tests/unit_tests/test_platformio_api.py | Adds 400+ lines of tests for PlatformIO API functionality including idedata caching, command execution, and stacktrace processing |
| tests/unit_tests/core/test_config.py | Adds 300+ lines of tests for core configuration validation, hostname checking, and platform detection |
| tests/unit_tests/conftest.py | Adds shared mock fixtures for file operations and external command execution |
jesserockz
approved these changes
Sep 14, 2025
Member
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Adds some more coverage ahead of the Path conversion
supports #10654
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: