8000
Skip to content

remove use of delay - #7680

Merged
jesserockz merged 2 commits into
esphome:devfrom
ssieb:sgp
Oct 29, 2024
Merged

remove use of delay#7680
jesserockz merged 2 commits into
esphome:devfrom
ssieb:sgp

Conversation

@ssieb
@ssieb ssieb commented Oct 26, 2024 •
edited
Loading
Copy link
Copy Markdown
Member

What does this implement/fix?

This removes the use of delay to wait for data and avoids the "component took too long" message.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable): #9517

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@ssieb
ssieb requested a review from martgras as a code owner October 26, 2024 00:43
@probot-esphome
probot-esphome Bot commented Oct 26, 2024
Copy link
Copy Markdown

Hey there @SenexCrenshaw, @martgras, mind taking a look at this pull request as it has been labeled with an integration (sgp4x) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
codecov-commenter commented Oct 26, 2024 •
edited
Loading
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.92%. Comparing base (4d8b5ed) to head (2ccf10c).
Report is 1537 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #7680      +/-   ##
==========================================
+ Coverage   53.70%   53.92%   +0.21%     
==========================================
  Files          50       50              
  Lines        9408     9765     +357     
  Branches     1654     1344     -310     
==========================================
+ Hits         5053     5266     +213     
- Misses       4056     4171     +115     
- Partials      299      328      +29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it he 8000 re.

jesserockz
jesserockz requested changes Oct 29, 2024
View reviewed changes
@jesserockz jesserockz left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small missing this stuck out, otherwise looks good to me

Comment thread esphome/components/sgp4x/sgp4x.cpp Outdated
@esphome
esphome Bot marked this pull request as draft October 29, 2024 03:47
@esphome
esphome Bot commented Oct 29, 2024
Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.
8000

@jesserockz
jesserockz marked this pull request as ready for review October 29, 2024 03:47
@esphome
esphome Bot requested a review from jesserockz October 29, 2024 03:47
@probot-esphome
probot-esphome Bot commented Oct 29, 2024
Copy link
Copy Markdown

Hey there @SenexCrenshaw, mind taking a look at this pull request as it has been labeled with an integration (sgp4x) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jesserockz
jesserockz enabled auto-merge (squash) October 29, 2024 03:47
@jesserockz
jesserockz merged commit 38dd566 into esphome:dev Oct 29, 2024
pauln pushed a commit to pauln/esphome that referenced this pull request Oct 30, 2024
@ssieb Samuel Sieb
@jesserockz @pauln
remove use of delay (esphome#7680)
dfaff6c 
Co-authored-by: Samuel Sieb <samuel@sieb.net>
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 31, 2024
@ssieb
ssieb deleted the sgp branch August 15, 2026 07:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@martgras martgras Awaiting requested review from martgras martgras is a code owner
@jesserockz jesserockz Awaiting requested review from jesserockz

Assignees

@martgras martgras

Labels

component: sgp4x

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ssieb @codecov-commenter @jesserockz @martgras
0