[openthread] channel range, fix typo, use C++17 nested namespace syntax - #12422
Conversation
|
To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file: external_components:
- source: github://pr#12422
components: [openthread, openthread_info]
refresh: 1h(Added by the PR bot) |
|
👋 Hi there! This PR modifies 4 file(s) with codeowners. @mrene - As codeowner(s) of the affected files, your review would be appreciated! 🙏 Note: Automatic review request may have failed, but you're still welcome to review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #12422 +/- ##
=======================================
Coverage 72.58% 72.58%
=======================================
Files 53 53
Lines 11192 11192
Branches 1517 1517
=======================================
Hits 8124 8124
Misses 2675 2675
Partials 393 393 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR modernizes the OpenThread component code with three distinct improvements: adopting C++17 nested namespace syntax, fixing a typo in a comment, and adding proper channel range validation for IEEE 802.15.4.
- Converted all namespace declarations from nested style to C++17 nested namespace syntax (
namespace esphome::openthread) - Fixed 8000 typo "suport" → "support" in TODO comment
- Added channel range validation (11-26) for OpenThread configuration
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
esphome/components/openthread_info/openthread_info_text_sensor.h |
Converted namespace declarations to C++17 syntax |
esphome/components/openthread_info/openthread_info_text_sensor.cpp |
Converted namespace declarations to C++17 syntax |
esphome/components/openthread/openthread_esp.cpp |
Converted namespace declarations to C++17 syntax |
esphome/components/openthread/openthread.h |
Converted namespace declarations to C++17 syntax |
esphome/components/openthread/openthread.cpp |
Converted namespace declarations to C++17 syntax |
esphome/components/openthread/__init__.py |
Fixed typo in comment and added channel range validation for IEEE 802.15.4 |
Memory Impact AnalysisComponents:
This analysis runs automatically when components change. Memory usage is measured from a merged configuration with 2 components. |
What does this implement/fix?
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: