[wifi] Check for esp32_hosted on no wifi variants - #10528
Merged
Conversation
Contributor
|
To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file: external_components:
- source: github://pr#10528
components: [wifi]
refresh: 1h(Added by the PR bot) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #10528 +/- ##
==========================================
+ Coverage 60.46% 60.56% +0.09%
==========================================
Files 51 51
Lines 10422 10440 +18
Branches 1390 1390
==========================================
+ Hits 6302 6323 +21
+ Misses 3762 3758 -4
- Partials 358 359 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
swoboda1337
force-pushed
the
p4_wifi_check
branch
2 times, most recently
from
September 2, 2025 22:49
50a5b22 to
ec3fd47
Compare
jesserockz
requested changes
Sep 3, 2025
Comment on lines
+182
to
+183
| integrations = CORE.loaded_integrations | ||
| if variant in NO_WIFI_VARIANTS and "esp32_hosted" not in integrations: |
Member
There was a problem hiding this comment.
Since this is in FINAL_VALIDATE_SCHEMA, it should use fv.full_config.get()
Suggested change
| integrations = CORE.loaded_integrations | |
| if variant in NO_WIFI_VARIANTS and "esp32_hosted" not in integrations: | |
| if variant in NO_WIFI_VARIANTS and "esp32_hosted" not in fv.full_config.get(): |
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
swoboda1337
force-pushed
the
p4_wifi_check
branch
from
September 3, 2025 11:30
ec3fd47 to
b1d7160
Compare
swoboda1337
marked this pull request as ready for review
September 3, 2025 11:30
jesserockz
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Check for esp32_hosted on no wifi variants
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: