8000
Skip to content

[mipi_spi] Add model - #10392

Merged
jesserockz merged 1 commit into
esphome:devfrom
clydebarrow:mipi-spi
Aug 24, 2025
Merged

[mipi_spi] Add model#10392
jesserockz merged 1 commit into
esphome:devfrom
clydebarrow:mipi-spi

Conversation

@clydebarrow
@clydebarrow clydebarrow commented Aug 23, 2025
Copy link
Copy Markdown
Contributor

What does this implement/fix?

Add jc3636w518 version 2 display.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • nRF52840

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Copilot AI review requested due to automatic review settings August 23, 2025 06:49
@github-actions
Copy link
Copy Markdown
Contributor

To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file:

external_components:
  - source: github://pr#10392
    components: [mipi_spi]
    refresh: 1h

(Added by the PR bot)

Copilot AI left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for a new display model - the JC3636W518V2 MIPI SPI display with 360x360 resolution. The change extends the existing jc.py models file to include configuration for this specific display variant.

  • Adds a new DriverChip configuration for the JC3636W518V2 display model
  • Includes comprehensive initialization sequence with gamma correction and display timing parameters
  • Configures the display for quad SPI bus mode with RGB color order and inverted colors

@codecov-commenter
codecov-commenter commented Aug 23, 2025
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.45%. Comparing base (5cd9a86) to head (d454d85).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10392   +/-   ##
=======================================
  Coverage   60.45%   60.45%           
=======================================
  Files          51       51           
  Lines       10417    10417           
  Branches     1388     1388           
=======================================
  Hits         6298     6298           
  Misses       3760     3760           
  Partials      359      359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jesserockz
jesserockz merged commit be9c20c into esphome:dev Aug 24, 2025
34 of 39 checks passed
abel-msk pushed a commit to abel-msk/esphome that referenced this pull request Aug 24, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0