8000
Skip to content

Add support for V2 of the waveshare 5.83in e-paper display. - #3660

Merged
jesserockz merged 6 commits into
esphome:devfrom
cooki35:waveshare_5p83in_v2
May 1, 2023
Merged

Add support for V2 of the waveshare 5.83in e-paper display.#3660
jesserockz merged 6 commits into
esphome:devfrom
cooki35:waveshare_5p83in_v2

Conversation

@cooki35
@cooki35 cooki35 commented Jul 28, 2022 •
edited
Loading
Copy link
Copy Markdown
Contributor

What does this implement/fix?

Add code to support the WaveShare 5.83in black & white displays with "V2" stickers on them.
The resolution of the V2 version changed (from 600x448) to 648x480.
The init and display code differ from the original 5.83in version.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes esphome/issues#2121

Pull request in esphome-docs with documentation (if applicable): esphome/esphome.io#2200

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

The display was connected with the WaveShare e-Paper Driver HAT Rev2.2 and via SPI to an ESP32 (esp32doit-devkit-v1).
The switches of the driver HAT were set to:

  • Display Config: B (0.47R)
  • Interface Config 0 (4-line SPI)

Example entry for config.yaml:

# Example config.yaml
spi:
  clk_pin: GPIO18
  mosi_pin: GPIO23
  id: spi001

display:
  - platform: waveshare_epaper_test
    spi_id: spi001
    cs_pin: GPIO5
    dc_pin: GPIO19
    busy_pin: GPIO16
    reset_pin: GPIO17
    model: 5.83inv2
    update_interval: 30s
    reset_duration: 2ms
    id: eink
    lambda: |-
      it.line(10, 10, 630, 10, COLOR_ON);

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@cooki35 cooki35 mentioned this pull request Jul 28, 2022
Merged
2 tasks
@cooki35
cooki35 marked this pull request as ready for review July 28, 2022 16:56
@github-actions
github-actions Bot commented Oct 27, 2022
Copy link
Copy Markdown
Contributor

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Oct 27, 2022
ssieb
ssieb requested changes Oct 27, 2022
View reviewed changes
Comment thread esphome/components/waveshare_epaper/waveshare_epaper.cpp Outdated
Comment on lines +948 to +956
/*
// Reset
this->reset_pin_->digital_write(false);
delay(20);
this->reset_pin_->digital_write(true);
delay(5);
this->reset_pin_->digital_write(false);
delay(20);
*/
@ssieb ssieb Oct 27, 2022
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this commented out? If it's not needed, then just remove it.

@github-actions github-actions Bot removed the stale label Oct 28, 2022
@TheStork239
TheStork239 commented Oct 29, 2022
Copy link
Copy Markdown

Is work still being done on this? It would be great to get it over the line, so that the newer 5.83in displays would be usable.
@cooki35 is the change that @ssieb requested doable?

@TheStork239
TheStork239 commented Dec 29, 2022
Copy link
Copy Markdown

This looks like it would be ready to go, apart from the one change requested by the review.
@cooki35, are you planning on making that edit to move this PR forward? It would be great to have the 5.83 v2 supported.

@izacq
izacq commented Jan 16, 2023
Copy link
Copy Markdown

Just tested it, works great, thanks @cooki35

@cooki35
cooki35 commented Mar 21, 2023
Copy link
Copy Markdown
Contributor Author

The changes sound reasonable, I forgot to delete the comments. I removed them. Thanks @ssieb !

@jesserockz
jesserockz merged commit bd6d6ca into esphome:dev May 1, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators May 3, 2023
@cooki35
cooki35 deleted the waveshare_5p83in_v2 branch July 26, 2023 11:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ssieb ssieb ssieb requested changes
@jesserockz jesserockz jesserockz approved these changes

Assignees

No one assigned

Labels

component: waveshare_epaper

Projects

No open projects
ESPHome Dev
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WaveShare e-paper 5.83in V2 display not working

6 participants

@cooki35 @TheStork239 @izacq @ssieb @jesserockz @nielsnl68
0