8000
Skip to content

[deep_sleep] Fix GPIO wakeup comment - #12815

Merged
swoboda1337 merged 1 commit into
esphome:devfrom
jvanderneutstulen:fix-gpio-wakeup-comment
Jan 12, 2026
Merged

[deep_sleep] Fix GPIO wakeup comment#12815
swoboda1337 merged 1 commit into
esphome:devfrom
jvanderneutstulen:fix-gpio-wakeup-comment

Conversation

@jvanderneutstulen
@jvanderneutstulen jvanderneutstulen commented Jan 2, 2026
Copy link
Copy Markdown
Contributor

According to the API reference: IOs that are powered by the VDD3P3_RTC power domain can be used to wake up the chip from Deep-sleep.

What does this implement/fix?

Fix typo in code comment.

Types of changes

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Developer breaking change (an API change that could break external components)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • nRF52840

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@jvanderneutstulen
[deep_sleep] Fix GPIO wakeup comment
996750c 
According to the API reference: IOs that are powered by the VDD3P3_RTC
power domain can be used to wake up the chip from Deep-sleep.
@github-actions
github-actions Bot commented Jan 2, 2026
Copy link
Copy Markdown
Contributor

To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file:

external_components:
  - source: github://pr#12815
    components: [deep_sleep]
    refresh: 1h

(Added by the PR bot)

@codecov-commenter
codecov-commenter commented Jan 2, 2026 •
edited
Loading
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.31%. Comparing base (763515d) to head (996750c).

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev   #12815      +/-   ##
==========================================
- Coverage   73.34%   73.31%   -0.03%     
==========================================
  Files          53       53              
  Lines       11284    11284              
  Branches     1531     1531              
==========================================
- Hits         8276     8273       -3     
- Misses       2608     2610       +2     
- Partials      400      401       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
github-actions Bot commented Jan 2, 2026
Copy link
Copy Markdown
Contributor

Memory Impact Analysis

Components: deep_sleep
Platform: esp32-idf

Metric Target Branch This PR Change
RAM 12,148 bytes 12,148 bytes ➡️ +0 bytes (0.00%)
Flash 229,011 bytes 229,011 bytes ➡️ +0 bytes (0.00%)

Note: This analysis measures static RAM and Flash usage only (compile-time allocation).
Dynamic memory (heap) cannot be measured automatically.
⚠️ You must test this PR on a real device to measure free heap and ensure no runtime memory issues.

This analysis runs automatically when components change. Memory usage is measured from a representative test configuration.

@swoboda1337
swoboda1337 merged commit 0c3433d into esphome:dev Jan 12, 2026
36 checks passed
@swoboda1337
swoboda1337 commented Jan 12, 2026
Copy link
Copy Markdown
Member

Thanks

@github-actions github-actions Bot locked and limited conversation to collaborators Jan 14, 2026
@jvanderneutstulen
jvanderneutstulen deleted the fix-gpio-wakeup-comment branch January 21, 2026 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@swoboda1337 swoboda1337 swoboda1337 approved these changes

Assignees

No one assigned

Labels

code-quality component: deep_sleep small-pr PR < 30 lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvanderneutstulen @codecov-commenter @swoboda1337
0