[climate] Accept °K as intended - #8134
Merged
Merged
Conversation
There seems to be a copy/paste typo with visual temperature support. This probably slipped through as hardly anyone is using Kelvin, and while technically there is no such thing as °K, we do want to have correct code. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8134 +/- ##
==========================================
+ Coverage 53.70% 53.87% +0.16%
==========================================
Files 50 50
Lines 9408 9834 +426
Branches 1654 1354 -300
==========================================
+ Hits 5053 5298 +245
- Misses 4056 4215 +159
- Partials 299 321 +22 ☔ View full report in Codecov by Sentry. |
DjordjeMandic
approved these changes
Jan 24, 2025
guillempages
approved these changes
Jan 28, 2025
Contributor
|
Maybe just make it |
jesserockz
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
There seems to be a copy/paste typo with visual temperature support. This probably slipped through as hardly anyone is using Kelvin, and while technically there is no such thing as °K, we do want to have correct code.
Types of changes
Test Environment
Checklist:
tests/folder).I currently don't have the means to check this myself.