Fix IDFI2CBus::writev ignoring stop parameter - #4840
Merged
Conversation
Co-authored-by: Alexander Dimitrov <admin@sharkydog.info>
|
Hey there @esphome/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Contributor
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
Contributor
Author
|
I don't see anything wrong with this |
jesserockz
approved these changes
Aug 15, 2023
Merged
jesserockz
pushed a commit
that referenced
this pull request
Aug 16, 2023
Co-authored-by: Alexander Dimitrov <admin@sharkydog.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
esphome/issues#4488
@sharkydog says this fixes the implementation on
I2CBus::writev'sstopparameter.Types of changes
Related issue or feature (if applicable): fixes esphome/issues#4488
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Checklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: