8000
Skip to content

Fix a bunch of components for IDF 5 compatibility and #6802 - #6805

Merged
jesserockz merged 12 commits into
esphome:devfrom
kbx81:20240524-idf-5-fixes
May 29, 2024
Merged

Fix a bunch of components for IDF 5 compatibility and #6802#6805
jesserockz merged 12 commits into
esphome:devfrom
kbx81:20240524-idf-5-fixes

Conversation

@kbx81
@kbx81 kbx81 commented May 25, 2024
Copy link
Copy Markdown
Member

What does this implement/fix?

Fix a bunch of components for IDF 5 compatibility -- merge before #6802

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@kbx81
kbx81 requested a review from jesserockz as a code owner May 25, 2024 03:20
@probot-esphome
probot-esphome Bot commented May 25, 2024
Copy link
Copy Markdown

Hey there @latonita, mind taking a look at this pull request as it has been labeled with an integration (ina2xx_base) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
probot-esphome Bot commented May 25, 2024
Copy link
Copy Markdown

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (i2s_audio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
probot-esphome Bot commented May 25, 2024
Copy link
Copy Markdown

Hey there @OnFreund, @alexborro, @loongyh, mind taking a look at this pull request as it has been labeled with an integration (fingerprint_grow) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
probot-esphome Bot commented May 25, 2024
Copy link
Copy Markdown

Hey there @DrCoolzic, mind taking a look at this pull request as it has been labeled with an integration (weikai) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
probot-esphome Bot commented May 25, 2024
Copy link
Copy Markdown

Hey there @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (voice_assistant) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@probot-esphome
probot-esphome Bot commented May 25, 2024
Copy link
Copy Markdown

Hey there @betterengineering, mind taking a look at this pull request as it has been labeled with an integration (htu31d) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@codecov-commenter
codecov-commenter commented May 25, 2024 •
edited
Loading
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.13%. Comparing base (4d8b5ed) to head (281b6f0).
Report is 681 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #6805      +/-   ##
==========================================
+ Coverage   53.70%   54.13%   +0.42%     
==========================================
  Files          50       50              
  Lines        9408     9619     +211     
  Branches     1654     1698      +44     
==========================================
+ Hits         5053     5207     +154     
- Misses       4056     4086      +30     
- Partials      299      326      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbx81 kbx81 mentioned this pull request May 26, 2024
Merged
13 tasks
This was referenced May 27, 2024
Closed
Closed
@kbx81
kbx81 requested a review from clydebarrow as a code owner May 27, 2024 05:13
@DrCoolzic
DrCoolzic commented May 27, 2024 •
edited
Loading
Copy link
Copy Markdown
Contributor

I have checked the modifications of Weikai component and they are fine for me

@DAVe3283 DAVe3283 mentioned this pull request May 28, 2024
Closed
13 tasks
@DAVe3283
DAVe3283 commented May 28, 2024
Copy link
Copy Markdown
Contributor

FYI I have a PR #6824 that will resolve the build errors for mitsubishi by switching away from the current (IMO unnecessary) use of uint32_t for 8-bit values. Then the log format doesn't need to be updated at all, and remains readable.

@jesserockz
jesserockz merged commit bff24e2 into esphome:dev May 29, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jesserockz jesserockz jesserockz approved these changes
@clydebarrow clydebarrow Awaiting requested review from clydebarrow clydebarrow is a code owner

Assignees

@jesserockz jesserockz

Labels

component: ade7953_base component: fingerprint_grow component: htu31d component: ina2xx_base component: remote_base component: weikai

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kbx81 @codecov-commenter @DrCoolzic @DAVe3283 @jesserockz
0