8000
Skip to content

add rp2040 support to the wizard - #6239

Merged
jesserockz merged 6 commits into
esphome:devfrom
fodfodfod:add-rp2040-to-wizard
May 20, 2024
Merged

add rp2040 support to the wizard#6239
jesserockz merged 6 commits into
esphome:devfrom
fodfodfod:add-rp2040-to-wizard

Conversation

@fodfodfod
@fodfodfod fodfodfod commented Feb 18, 2024 •
edited
Loading
Copy link
Copy Markdown
Contributor

What does this implement/fix?

This adds support for the raspberry pi pico and pico w to the ESPHome wizard.

It still prompts the user to setup wifi even on the rpipico which doesn't support wifi. The wifi credentials will no longer be written in #5832, but they will still be prompted for.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes NA

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs# NA

Test Environment

  • ESP32
  • ESP8266
  • RP2040
  • BK72xx
  • ESP32 IDF
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml
esphome:
  name: livingroom

rp2040:
  board: rpipicow
  framework:
    # Required until https://github.com/platformio/platform-raspberrypi/pull/36 is merged
    platform_version: https://github.com/maxgerhardt/platform-raspberrypi.git

# Enable logging
logger:

# Enable Home Assistant API
api:
  password: ""

ota:
  password: ""

wifi:
  ssid: "Abraham Linksys"
  password: "PASSWORD42"

  # Enable fallback hotspot in case wifi connection fails
  ap:
    ssid: "Livingroom Fallback Hotspot"
    password: "R1QCMXo0AThz"

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@fodfodfod
fodfodfod requested a review from a team as a code owner February 18, 2024 17:09
@probot-esphome probot-esphome Bot added core small-pr PR < 30 lines labels Feb 18, 2024
@codecov-commenter
codecov-commenter commented Feb 18, 2024 •
edited
Loading
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 54.09%. Comparing base (4d8b5ed) to head (c53e6f2).
Report is 630 commits behind head on dev.

Files Patch % Lines
esphome/wizard.py 83.33% 6 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #6239      +/-   ##
==========================================
+ Coverage   53.70%   54.09%   +0.38%     
==========================================
  Files          50       50              
  Lines        9408     9627     +219     
  Branches     1654     1701      +47     
==========================================
+ Hits         5053     5208     +155     
- Misses       4056     4092      +36     
- Partials      299      327      +28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fodfodfod fodfodfod changed the title add rp2040 support to the wizard add rp2040 support to the wizard (#2711) May 3, 2024
@fodfodfod fodfodfod changed the title add rp2040 support to the wizard (#2711) add rp2040 support to the wizard May 3, 2024
@fodfodfod fodfodfod mentioned this pull request May 3, 2024
Closed
jesserockz
jesserockz reviewed May 5, 2024
View reviewed changes
@jesserockz jesserockz left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. We can probably alter the flow to skip the wifi questions for known platforms/boards that dont have wifi.

@probot-esphome probot-esphome Bot removed the small-pr PR < 30 lines label May 19, 2024
@fodfodfod
fodfodfod commented May 19, 2024
Copy link
Copy Markdown
Contributor Author

The wizard will no longer prompt for wifi info on boards that don't support it.

@jesserockz
jesserockz merged commit b9bb3cd into esphome:dev May 20, 2024
@fodfodfod
fodfodfod deleted the add-rp2040-to-wizard branch May 20, 2024 00:57
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fodfodfod @codecov-commenter @jesserockz
0