Remove the choice for MQTT logging if it is disabled - #7723
Merged
jesserockz merged 3 commits intoNov 11, 2024
Conversation
This is a second pass at esphome/issues#6046 I have a situation where sometimes I have MQTT logging enabled, but sometimes not depending on the device. This PR removes the choice so that one doesn't have to remember that MQTT logging is disabled, so that `esphome logs` goes right for the API method (if available).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7723 +/- ##
==========================================
+ Coverage 53.70% 53.95% +0.24%
==========================================
Files 50 50
Lines 9408 9775 +367
Branches 1654 1347 -307
==========================================
+ Hits 5053 5274 +221
- Misses 4056 4175 +119
- Partials 299 326 +27 ☔ View full report in Codecov by Sentry. |
jesserockz
requested changes
Nov 5, 2024
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
solarkennedy
marked this pull request as ready for review
November 6, 2024 04:29
Contributor
Author
|
Added in requested changes |
jesserockz
approved these changes
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a second pass at esphome/issues#6046
I have a situation where sometimes I have MQTT logging enabled, but sometimes not depending on the device.
This PR removes the choice so that one doesn't have to remember that MQTT logging is disabled, so that
esphome logsgoes right for the API method (if available).What does this implement/fix?
Types of changes
Related issue or feature (if applicable):
Pull request in esphome-docs with documentation (if applicable):
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: