8000 8000
Skip to content

Publish NAN when dallas conversion failed - #3227

Merged
OttoWinter merged 1 commit into
devfrom
dallas-conversion-failed-nan
Feb 19, 2022
Merged

Publish NAN when dallas conversion failed#3227
OttoWinter merged 1 commit into
devfrom
dallas-conversion-failed-nan

Conversation

@OttoWinter
@OttoWinter OttoWinter commented Feb 19, 2022
Copy link
Copy Markdown
Member

What does this implement/fix?

Fixes esphome/feature-requests#1639

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@OttoWinter OttoWinter added this to the 2022.2.4 milestone Feb 19, 2022
@OttoWinter
OttoWinter merged commit d594f43 into dev Feb 19, 2022
@OttoWinter
OttoWinter deleted the dallas-conversion-failed-nan branch February 19, 2022 13:11
@jesserockz jesserockz mentioned this pull request Feb 20, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Report Dallas "Requested conversion failed" back

2 participants

0