8000
Skip to content

[wifi] Disallow psram config with arduino - #9922

Merged
kbx81 merged 3 commits into
esphome:devfrom
clydebarrow:wifi-psram
Jul 27, 2025
Merged

[wifi] Disallow psram config with arduino#9922
kbx81 merged 3 commits into
esphome:devfrom
clydebarrow:wifi-psram

Conversation

@clydebarrow
@clydebarrow clydebarrow commented Jul 27, 2025
Copy link
Copy Markdown
Contributor

What does this implement/fix?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx
  • nRF52840

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

Copilot AI review requested due to automatic review settings July 27, 2025 04:58
@github-actions
github-actions Bot commented Jul 27, 2025
Copy link
Copy Markdown
Contributor

To use the changes from this PR as an external component, add the following to your ESPHome configuration YAML file:

external_components:
  - source: github://pr#9922
    components: [wifi]
    refresh: 1h

(Added by the PR bot)

@esphome esphome Bot added component: wifi small-pr PR < 30 lines labels Jul 27, 2025
@clydebarrow
clydebarrow requested a review from bdraco July 27, 2025 04:58
Copilot AI reviewed Jul 27, 2025
View reviewed changes
Copilot AI l 8000 eft a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug by disallowing the use of PSRAM configuration with Arduino framework in the WiFi component. The change ensures that PSRAM configuration is only allowed when using the ESP-IDF framework.

  • Adds only_with_esp_idf validation to the use_psram configuration option
  • Imports the necessary validation function from the config validation module

Comment thread esphome/components/wifi/__init__.py Outdated
@codecov-commenter
codecov-commenter commented Jul 27, 2025 •
edited
Loading
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.07%. Comparing base (bcc5664) to head (df1dc68).

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9922      +/-   ##
==========================================
- Coverage   60.11%   60.07%   -0.04%     
==========================================
  Files          51       51              
  Lines       10302    10302              
  Branches     1371     1371              
==========================================
- Hits         6193     6189       -4     
- Misses       3754     3757       +3     
- Partials      355      356       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kbx81
kbx81 approved these changes Jul 27, 2025
View reviewed changes
@kbx81 kbx81 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏻

@kbx81
kbx81 merged commit a2ed209 into esphome:dev Jul 27, 2025
24 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 29, 2025
@clydebarrow
clydebarrow deleted the wifi-psram branch November 28, 2025 01:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@kbx81 kbx81 kbx81 approved these changes
@bdraco bdraco Awaiting requested review from bdraco

Assignees

No one assigned

Labels

bugfix component: wifi small-pr PR < 30 lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@clydebarrow @codecov-commenter @kbx81
0