8000
Skip to content

[ota] Increase socket timeout earlier in OTA script - #8129

Merged
jesserockz merged 1 commit into
esphome:devfrom
swoboda1337:binary_size_timed_out
Feb 10, 2025
Merged

[ota] Increase socket timeout earlier in OTA script#8129
jesserockz merged 1 commit into
esphome:devfrom
swoboda1337:binary_size_timed_out

Conversation

@swoboda1337
@swoboda1337 swoboda1337 commented Jan 23, 2025
Copy link
Copy Markdown
Member

What does this implement/fix?

Fixes OTA with larger binaries that some people have encountered:

ERROR Error receiving acknowledge binary size: timed out

Increase socket timeout earlier

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code quality improvements to existing code or addition of tests
  • Other

Related issue or feature (if applicable):

Pull request in esphome-docs with documentation (if applicable):

  • esphome/esphome-docs#

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@swoboda1337
swoboda1337 requested a review from a team as a code owner January 23, 2025 15:57
@probot-esphome probot-esphome Bot added core small-pr PR < 30 lines labels Jan 23, 2025
@codecov-commenter
codecov-commenter commented Jan 23, 2025 •
edited
Loading
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 53.87%. Comparing base (4d8b5ed) to head (7f50763).
Report is 1948 commits behind head on dev.

Files with missing lines Patch % Lines
esphome/espota2.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #8129      +/-   ##
==========================================
+ Coverage   53.70%   53.87%   +0.16%     
==========================================
  Files          50       50              
  Lines        9408     9834     +426     
  Branches     1654     1354     -300     
==========================================
+ Hits         5053     5298     +245     
- Misses       4056     4215     +159     
- Partials      299      321      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swoboda1337 swoboda1337 changed the title [ota2] Increase socket timeout earlier in OTA script [ota] Increase socket timeout earlier in OTA script Jan 24, 2025
@jesserockz
jesserockz merged commit 8be9f02 into esphome:dev Feb 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 12, 2025
@swoboda1337
swoboda1337 deleted the binary_size_timed_out branch July 2, 2025 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees

No one assigned

Labels

core small-pr PR < 30 lines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ERROR Error receiving acknowledge binary size: timed out OTA: ERROR Error receiving acknowledge binary size: timed out USB: ok

3 participants

@swoboda1337 @codecov-commenter @jesserockz
0