8000
Skip to content
/ esphome Public
< 8000 div id="repository-details-container" class="flex-shrink-0" data-turbo-replace style="max-width: 70%;">

duty_time: fix build without binary_sensor. Parented in automations. - #5156

Merged
jesserockz merged 5 commits into
esphome:devfrom
dudanov:duty_time-270723
Jul 30, 2023
Merged

duty_time: fix build without binary_sensor. Parented in automations.#5156
jesserockz merged 5 commits into
esphome:devfrom
dudanov:duty_time-270723

Conversation

@dudanov
@dudanov dudanov commented Jul 27, 2023 •
edited
Loading
Copy link
Copy Markdown
Contributor

What does this implement/fix?

  1. Fixed building then binary_sensor is not loaded. Preferred preprocessor directives to AUTO_LOAD since use is optional;
  2. Automation used Parented<T>.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@dudanov
dudanov marked this pull request as draft July 27, 2023 14:28
@dudanov
dudanov force-pushed the duty_time-270723 branch from 8780695 to d451fdd Compare July 27, 2023 18:25
@dudanov
dudanov force-pushed the duty_time-270723 branch from dc6896b to 4f9abb4 Compare July 27, 2023 20:51
@dudanov dudanov closed this Jul 30, 2023
@dudanov dudanov reopened this Jul 30, 2023
@dudanov
dudanov marked this pull request as ready for review July 30, 2023 20:26
jesserockz
jesserockz requested changes Jul 30, 2023
View reviewed changes
Comment thread esphome/components/duty_time/sensor.py Outdated
Comment thread esphome/components/duty_time/sensor.py Outdated
Comment thread esphome/components/duty_time/sensor.py Outdated
Comment thread esphome/components/duty_time/sensor.py Outdated
dudanov and others added 4 commits July 31, 2023 00:59
@dudanov @jesserockz
Update esphome/components/duty_time/sensor.py
65de3a7 
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@dudanov @jesserockz
Update esphome/components/duty_time/sensor.py
2cc600b 
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@dudanov @jesserockz
Update esphome/components/duty_time/sensor.py
4cf8ad4 
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@dudanov @jesserockz
Update esphome/components/duty_time/sensor.py
c74be2b 
Co-authored-by: Jesse Hills <3060199+jesserockz@users.noreply.github.com>
@dudanov
dudanov requested a review from jesserockz July 30, 2023 21:01
@jesserockz
jesserockz enabled auto-merge (squash) July 30, 2023 21:10
@jesserockz
jesserockz merged commit 9ff0471 into esphome:dev Jul 30, 2023
@dudanov
dudanov deleted the duty_time-270723 branch July 31, 2023 04:23
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jesserockz jesserockz jesserockz approved these changes

Assignees

No one assigned

Labels

by-code-owner component: duty_time

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dudanov @jesserockz
0