8000
Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Dump native API Server config on boot - #338

Merged
OttoWinter merged 4 commits into
esphome:devfrom
voicevon:api_server
Dec 30, 2018
Merged

Dump native API Server config on boot#338
OttoWinter merged 4 commits into
esphome:devfrom
voicevon:api_server

Conversation

@voicevon
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/esphomelib/api/api_server.cpp Outdated
}
void APIServer::dump_config() {

ESP_LOGI(TAG,"API Server:");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an info message, it's a config message.
Space missing after comma.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I will use ESP_LOGCONFIG().Thanks.

@OttoWinter OttoWinter changed the title Api server dump_config() should not be empty Dump native API Server config on boot Dec 30, 2018
@OttoWinter
OttoWinter merged commit db3d520 into esphome:dev Dec 30, 2018
@voicevon
voicevon deleted the api_server branch December 31, 2018 03:37
@esphome esphome locked and limited conversation to collaborators Jun 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0