8000
Skip to content

Move formatter<std::error_code> from fmt/os.h to fmt/std.h#3125

Merged
vitaut merged 1 commit intofmtlib:masterfrom
phprus:format-error_code-2
Oct 2, 2022
Merged

Move formatter<std::error_code> from fmt/os.h to fmt/std.h#3125
vitaut merged 1 commit intofmtlib:masterfrom
phprus:format-error_code-2

Conversation

@phprus
Copy link
Copy Markdown
Contributor
@phprus phprus commented Oct 1, 2022

Issue: #3123

vitaut
vitaut reviewed Oct 1, 2022
View reviewed changes
@phprus
Move formatter<std::error_code> from fmt/os.h to fmt/std.h
720f562 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@phprus phprus force-pushed the format-error_code-2 branch from 0d55cef to 720f562 Compare October 1, 2022 22:03
@vitaut vitaut merged commit 662adf4 into fmtlib:master Oct 2, 2022
@vitaut
Copy link
Copy Markdown
Contributor
vitaut commented Oct 2, 2022

Thank you!

@tupaschoal
Copy link
Copy Markdown
Contributor
tupaschoal commented Jan 9, 2024

Should this PR also have touched documentation for std.h? It currently does not say that it provides formatting for error_code, just:

fmt/std.h provides formatters for:

[std::filesystem::path](https://en.cppreference.com/w/cpp/filesystem/path)

[std::thread::id](https://en.cppreference.com/w/cpp/thread/thread/id)

[std::monostate](https://en.cppreference.com/w/cpp/utility/variant/monostate)

[std::variant](https://en.cppreference.com/w/cpp/utility/variant/variant)

[std::optional](https://en.cppreference.com/w/cpp/utility/optional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitaut vitaut vitaut left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phprus @vitaut @tupaschoal
0