Allowing formatting non-copyable ranges.#3290
Merged
vitaut merged 4 commits intofmtlib:masterfrom Jan 27, 2023
Merged
Conversation
…st need to make that one non-const.
Contributor
Author
|
Some windows build is complaining about |
Contributor
|
It's not an exact match, but the general "era" matches "x64 msvc v19.0 (WINE)". |
Contributor
Author
|
wat: https://godbolt.org/z/b9TYxqh6s namespace my {
namespace detail {
template <typename... > using void_t = void;
}
}
template <typename T>
struct has_mutable_begin_end<
T,
#if 1
fmt::detail::void_t<
#else
my::detail::void_t<
#endif
decltype(fmt::detail::range_begin(std::declval<T>()))
, decltype(fmt::detail::range_end(std::declval<T>()))
#if 0
, int
#endif
>>
: std::true_type {};
static_assert(has_mutable_begin_end<noncopyable_range>::value, "");If I use If I use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3286