8000
Skip to content

Export all range join overloads#4239

Merged
vitaut merged 1 commit intofmtlib:masterfrom
Arghnews:export_join
Nov 15, 2024
Merged

Export all range join overloads#4239
vitaut merged 1 commit intofmtlib:masterfrom
Arghnews:export_join

Conversation

@Arghnews
Copy link
Copy Markdown
Contributor
@Arghnews Arghnews commented Nov 14, 2024

Fixes #4190
Have tested on my local machine and couldn't compile

  auto v = std::vector<std::string>{"1", "2", "3"};
    fmt::print("{}", fmt::join(v, ", "));

Without this, now can

Don't think can write a test for this change as currently the tests use:

fmt/test/CMakeLists.txt

Lines 101 to 112 in 9ced61b

if (FMT_MODULE)
# The tests need {fmt} to be compiled as traditional library
# because of visibility of implementation details.
# If module support is present the module tests require a
# test-only module to be built from {fmt}
add_library(test-module OBJECT ${CMAKE_SOURCE_DIR}/src/fmt.cc)
target_compile_features(test-module PUBLIC cxx_std_11)
target_include_directories(test-module PUBLIC
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/include>)
enable_module(test-module)
add_fmt_test(module-test MODULE test-main.cc)

Which is presumably how it doesn't get picked up an not-exported right now. A test for its usage does already exist anyway:

fmt/test/module-test.cc

Lines 385 to 394 in 9ced61b

TEST(module_test, join) {
int arr[3] = {1, 2, 3};
std::vector<double> vec{1.0, 2.0, 3.0};
std::initializer_list<int> il{1, 2, 3};
auto sep = fmt::string_view(", ");
EXPECT_EQ("1, 2, 3", to_string(fmt::join(arr + 0, arr + 3, sep)));
EXPECT_EQ("1, 2, 3", to_string(fmt::join(arr, sep)));
EXPECT_EQ("1, 2, 3", to_string(fmt::join(vec.begin(), vec.end(), sep)));
EXPECT_EQ("1, 2, 3", to_string(fmt::join(vec, sep)));
EXPECT_EQ("1, 2, 3", to_string(fmt::join(il, sep)));

@vitaut vitaut merged commit 536cabd into fmtlib:master Nov 15, 2024
@vitaut
Copy link
Copy Markdown
Contributor
vitaut commented Nov 15, 2024

Thank you!

This was referenced Dec 25, 2024
Merged
Closed
Closed
Merged
This was referenced Mar 3, 2025
Closed
Closed
@renovate renovate bot mentioned this pull request Apr 26, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request May 31, 2025
Merged
1 task
@renovate renovate bot mentioned this pull request Jun 11, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

join couldn't be found an appropriate overload when fmt is imported as a module.

2 participants

@Arghnews @vitaut
0