Add localized formatting to non-decimal presentation types of ints#3750
Merged
vitaut merged 10 commits intofmtlib:masterfrom Dec 15, 2023
Merged
Add localized formatting to non-decimal presentation types of ints#3750vitaut merged 10 commits intofmtlib:masterfrom
vitaut merged 10 commits intofmtlib:masterfrom
Conversation
phprus
reviewed
Dec 12, 2023
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #3693 by adding a slightly modified version of the switch statement of presentation types, which is used in the default
write_int()function without the locale option, to thewrite_int()handling writes with the locale grouping. Added tests as well.