Merged
Conversation
b19310b to
ed407d8
Compare
vitaut
reviewed
Apr 29, 2023
Contributor
There was a problem hiding this comment.
Thanks for the PR! Mostly looks good, just one comment inline.
include/fmt/format.h
Outdated
Comment on lines
+1042
to
+1045
| FMT_BEGIN_DETAIL_NAMESPACE | ||
| FMT_API bool write_console(std::FILE* f, string_view text); | ||
| FMT_API void print(std::FILE*, string_view); | ||
| } // namespace detail | ||
| FMT_END_DETAIL_NAMESPACE |
Contributor
There was a problem hiding this comment.
I think we should use FMT_{BEGIN,END}_EXPORT instead of "magically" folding exports into namespace macros.
- don't export names from `detail` - put more headers into the global module fragment - support MSYS2 and Clang
ed407d8 to
728333c
Compare
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detail