Suppress gcc warning on privates-only class#2053
Merged
vitaut merged 1 commit intofmtlib:masterfrom Dec 9, 2020
Merged
Conversation
vitaut
requested changes
Dec 8, 2020
Contributor
There was a problem hiding this comment.
The warning can be suppressed in a simpler way by adding a defaulted ctor.
770699a to
f0b7578
Compare
Since gcc 9 it warns about is_streamable to have only private methods. Add explicit default ctor instead of suppression
Contributor
Author
|
oh yes... that's much less invasive |
Contributor
|
Thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since gcc 9 it warns about is_streamable to have only private methods.
I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.