8000
Skip to content

Force use a signed char (On ARM char is unsigned by default)#3362

Merged
vitaut merged 1 commit intofmtlib:masterfrom
phprus:chrono-test-char
Mar 22, 2023
Merged

Force use a signed char (On ARM char is unsigned by default)#3362
vitaut merged 1 commit intofmtlib:masterfrom
phprus:chrono-test-char

Conversation

@phprus
Copy link
Copy Markdown
Contributor
@phprus phprus commented Mar 22, 2023

Environment:

docker-desktop:/ # uname -a
Linux docker-desktop 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux

Error:

[ RUN      ] chrono_test.cpp20_duration_subsecond_support
/fmt/fmt-master/test/chrono-test.cc:823: Failure
Expected equality of these values:
  fmt::format("{:%S}", std::chrono::duration<char, std::ratio<1, 100>>(0x80))
    Which is: "01.28"
  "-01.28"
[  FAILED  ] chrono_test.cpp20_duration_subsecond_support (0 ms)

On ARM gcc char is unsigned:
https://developer.arm.com/documentation/den0013/d/Porting/Miscellaneous-C-porting-issues/unsigned-char-and-signed-char
https://trofi.github.io/posts/203-signed-char-or-unsigned-char.html

@phprus
Force use a signed char (On ARM char is unsigned by default)
a5dc450 
Signed-off-by: Vladislav Shchapov <vladislav@shchapov.ru>
@vitaut vitaut merged commit f6276a2 into fmtlib:master Mar 22, 2023
@vitaut
Copy link
Copy Markdown
Contributor
vitaut commented Mar 22, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phprus @vitaut
0