Add support for If Expression #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yazaldefilimone
requested changes
Apr 18, 2025
| } | ||
| }; | ||
| self.register_type(if_expr_typed, if_expr.get_range()); | ||
| Ok(self.owned_typed_value(if_expr_typed)) |
Owner
There was a problem hiding this comment.
we need to return borrow union here, I am currently impl this... @edilson258 is ok to wait for it?
Contributor
Author
There was a problem hiding this comment.
and that union is suppose to be only used internally??
Owner
There was a problem hiding this comment.
yes... exemple we need to tracker a owner value for all possible return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Add support for
ifexpressions (ternary-like operator)This PR introduces support for
ifexpressions, allowing conditional assignment in expression form, similar to the ternary operator in other languages.✅ Example usage: