Stop requiring eslint as a production dependency#15
Merged
smusali merged 1 commit intologdna:masterfrom Jun 25, 2020
s100:patch-1
Merged
Stop requiring eslint as a production dependency#15smusali merged 1 commit intologdna:masterfrom s100:patch-1
eslint as a production dependency#15smusali merged 1 commit intologdna:masterfrom
s100:patch-1
Conversation
Contributor
|
@s100, we have just released the newest patch version including this change. Thanks again for reporting and fixing this! |
Contributor
Author
|
Thank you for acting promptly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears that
logdna-bunyandoes not useeslintat run time, only for linting at development time, so this PR removes that dependency.This PR is motivated by a prototype pollution vulnerability in
lodash, whicheslinthas a dependency on, and whichlodash's maintainers seem not to be acting on. By eliminatingeslintas a production dependency, we eliminate the transitive dependency onlodash.