dcsg · 2014-05-15T16:43:29Z

This change will allow people that extends Carbon to have correct typehint in the IDE.

extending Carbon.

jan-j · 2014-05-22T11:47:33Z

I'd really like to see this merged as soon as possible.

eduardosoliv · 2014-05-22T15:44:52Z

me as well

eduardosoliv · 2014-05-31T18:59:20Z

@briannesbitt this is a small change that avoid the use of vdoc's to get the right typehint, will be merged?

dcsg · 2014-06-20T14:35:45Z

@briannesbitt ping

briannesbitt · 2014-06-20T15:14:25Z

Which IDE's do you guys use to make this work better?

eduardosoliv · 2014-06-20T15:15:16Z

phpstorm

dcsg · 2014-06-20T15:23:17Z

@briannesbitt phpstorm

eduardosoliv · 2014-06-27T10:34:48Z

@briannesbitt sorry but why a simple phpdoc change that will help anyone using a quite good IDE takes a month and half to merge?

Right now all the code have to have

    /** @var Carbon $date*/

in order to have the correct typehint when extending Carbon

dcsg · 2014-07-17T14:46:26Z

@briannesbitt any news on this?

briannesbitt · 2014-07-18T03:32:18Z

Merged.

dcsg · 2014-07-18T08:54:41Z

thanks :)

nicholasnet · 2016-06-22T18:32:25Z

This merge fixes the extension issue but breaks other one. Consider this example.

class Foo
{
    /**
     * @var \Carbon\Carbon
     */
    protected $foo;

    public function __construct()
    {
        $this->foo = \Carbon\Carbon::now();
    }
}

class Bar extends Foo
{
    public function test()
    {
        $this->foo->format('Y-m-d'); // This won't resolve now because of static phpdoc comment.
    }
}

In my opinion we should think about this merge again.

Add plus() and minus() methods

Changed return type from Carbon to static to allow have TypeHinting when

5c10460

extending Carbon.

briannesbitt closed this Jul 18, 2014

dcsg deleted the return-type-to-static branch July 18, 2014 08:53

briannesbitt mentioned this pull request Jun 22, 2016

Fix phpdoc 8000 to return Carbon instead of static #681

Closed

kylekatarnls added a commit that referenced this pull request Jun 14, 2026

Merge pull request #124 from CarbonPHP/feature/plus-and-minus

5a09cc3

Add plus() and minus() methods

Navigation Menu

Uh oh!

Changed return type to static - #124