awslogs - don't add new lines to maximum sized events - #36078
Merged
Conversation
Signed-off-by: Justin Menga <justin.menga@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Justin Menga justin.menga@gmail.com
- What I did
This PR addresses an edge scenario where a maximum sized log event is received, in which case a new line character should not be inserted.
The PR also renames a few variables for better readability and adjusts the multiline event buffer to expire if the buffer age is greater than or equal to (rather than greater than) the batch publish frequency.
- How I did it
Only append a new line character if the log event size is less than the maximum event size
- How to verify it
The
TestCollectBatchMultilinePatternMaxEventSizetest verifies the edge case.- Description for the changelog
awslogs - don't add new lines to maximum sized events
- A picture of a cute animal (not mandatory but encouraged)