🪟🎉 Connector builder: Improve testing panel UX on invalid configuration - #22061
Merged
Conversation
Joe Reuter (flash1293)
marked this pull request as ready for review
January 31, 2023 13:25
Lake Mossman (lmossman)
approved these changes
Feb 1, 2023
Contributor
There was a problem hiding this comment.
Changes LGTM, tested locally and it works as expected. This UX is a lot better!
Joe Reuter (flash1293)
enabled auto-merge (squash)
February 2, 2023 14:17
This was referenced Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #20948 when working on that, I noticed a few other small issues that bothered me before, I tried to stabilize that as well.
Fixes a bunch of small inconsistencies in the testing panel:
airbyte-webapp/src/components/connectorBuilder/Builder/BuilderField.tsx) - add back the blurThe last one is especially important while editing the yaml - in this situation it's expected to jump quickly between error state and valid state and this PR makes sure the UI is not jumping around:
Kapture.2023-01-31.at.14.22.54.mp4
This is how it looked before (multiple jumps):
Kapture.2023-01-31.at.14.24.43.mp4
How
There is still a small delay before a newly created stream is shown in the testing panel - this is due to the debounce of moving the form values up to the builder state. I can't think of a good way to get rid of this at the moment, I hope that after the migration to react-hook-form we won't need this debounce anymore.