Allow users to cancel a currently running sync on a disabled connection - #22241
Merged
Mark Berger (m19berger) merged 2 commits intoFeb 6, 2023
Conversation
Volodymyr Petrov (dizel852)
approved these changes
Feb 3, 2023
Mark Berger (m19berger)
requested a review
from Edmundo Ruiz Ghanem (edmundito)
February 3, 2023 11:24
Edmundo Ruiz Ghanem (edmundito)
suggested changes
Feb 6, 2023
Contributor
There was a problem hiding this comment.
Tested and works great. I had some comments about the styling that can be improved.
- Changed logic to show/hide action buttons for Connections Status Page
Mark Berger (m19berger)
force-pushed
the
mark/allow-users-to-cancel_a-currently-running-sync-on-a-disabled-connection
branch
from
February 6, 2023 19:17
0e4d1b5 to
3812186
Compare
- Changed logic to show/hide action buttons for Connections Status Page
Mark Berger (m19berger)
requested a review
from Edmundo Ruiz Ghanem (edmundito)
February 6, 2023 20:52
Edmundo Ruiz Ghanem (edmundito)
approved these changes
Feb 6, 2023
Mark Berger (m19berger)
deleted the
mark/allow-users-to-cancel_a-currently-running-sync-on-a-disabled-connection
branch
February 6, 2023 22:13
This was referenced Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #22084
How
Changed logic to show/hide action buttons for the Connections Status Page
Now users have the possibility to cancel sync with a
disabledconnectionLoom
https://www.loom.com/share/bcb3f306ca6745ffbc2dab84fa570ffe