destination-bigquery: convert prod code to kotlin - #39904
Merged
Stephane Geneix (stephane-airbyte) merged 1 commit intoJun 21, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join Stephane Geneix (@stephane-airbyte) and the rest of your teammates on |
Stephane Geneix (stephane-airbyte)
force-pushed
the
stephane/06-20-destination-bigquery_convert_prod_code_to_kotlin
branch
4 times, most recently
from
June 20, 2024 23:43
d5b3743 to
35af9e4
Compare
Stephane Geneix (stephane-airbyte)
force-pushed
the
stephane/06-20-destination-bigquery_convert_prod_code_to_kotlin
branch
from
June 21, 2024 04:33
35af9e4 to
ea34e2f
Compare
Stephane Geneix (stephane-airbyte)
marked this pull request as ready for review
June 21, 2024 04:52
Stephane Geneix (stephane-airbyte)
requested a review
from a team
as a code owner
June 21, 2024 04:52
Stephane Geneix (stephane-airbyte)
requested review from
Edward Gao (edgao)
and removed request for
a team
June 21, 2024 04:52
This was referenced Jun 21, 2024
Edward Gao (edgao)
approved these changes
Jun 21, 2024
Contributor
There was a problem hiding this comment.
I only looked at the files with actual diffs, didn't check the other files at all. LGTM assuming CI succeeds.
Contributor
Author
Merge activity
|
Stephane Geneix (stephane-airbyte)
deleted the
stephane/06-20-destination-bigquery_convert_prod_code_to_kotlin
branch
June 21, 2024 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?