Source S3: keep processing but warn if OSError happen - #21604
Merged
Roman Yermilov [GL] (roman-yermilov-gl) merged 3 commits intoJan 24, 2023
Merged
Source S3: keep processing but warn if OSError happen#21604Roman Yermilov [GL] (roman-yermilov-gl) merged 3 commits into
Roman Yermilov [GL] (roman-yermilov-gl) merged 3 commits into
Conversation
Contributor
Author
|
/test connector=connectors/source-s3
Build PassedTest summary info: |
Comment on lines
+68
to
+70
| self.logger.warn(f"We don't have access to {self.url}. " | ||
| f"Check whether key {self.url} exists in `{bucket}` bucket and/or has proper ACL permissions") | ||
| raise e |
Contributor
There was a problem hiding this comment.
Does this produce an AirbyteTraceError message? Just logging to stdout won't help users learn what to do
Contributor
There was a problem hiding this comment.
cc Brian Lai (@brianjlai) maybe you recall the answer - does throwing an exception here end up making a useable AirbyteTraceErrorMessage?
Contributor
Author
There was a problem hiding this comment.
It does. But in this case I catch it in two possible places where it can be raised and handle it
Contributor
There was a problem hiding this comment.
Ok, this matches the philosophy that Ella Rohm-Ensing (@erohmensing) is working on with streams being unavailable - we sync what we can and log an error for the streams we can't reach. 👍
Serhii Lazebnyi (lazebnyi)
approved these changes
Jan 19, 2023
Daryna Ishchenko (darynaishchenko)
approved these changes
Jan 20, 2023
Contributor
Author
|
/publish connector=connectors/source-s3
if you have connectors that successfully published but failed definition generation, follow step 4 here |
Octavia Squidington III (octavia-squidington-iii)
temporarily deployed
to
more-secrets
January 23, 2023 10:48 — with 
GitHub Actions
Inactive
Octavia Squidington III (octavia-squidington-iii)
temporarily deployed
to
more-secrets
January 23, 2023 10:48 — with
GitHub Actions
Inactive
Contributor
Airbyte Code Coverage
|
Evan Tahler (evantahler)
approved these changes
Jan 23, 2023
Roman Yermilov [GL] (roman-yermilov-gl)
deleted the
ryermilov/source-s3-handle-oserror
branch
January 24, 2023 16:00
This was referenced Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Handle OSError which means no access to key in a bucket. Warn and keep working on another files which we have an access to