Source Sendgrid: unpin CDK version - #36455
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
looks good to me! I added the one comment about our switch to the new config so we don't lose context, but no changes needed for ✅
| discovery: | ||
| tests: | ||
| - config_path: "secrets/old_config.json" | ||
| - config_path: "secrets/config.json" |
There was a problem hiding this comment.
Noting that there seemed to be a very conscious change to switch from config.json to old_config.json in this PR back in 2022. The only difference in the files I pulled from GCS is start_time changing from "2019-05-20T13:43:57.000Z" to "2019-05-20T13:43:57Z".
But since it looks like CI tests are passing just fine now, I'm good with the change and thanks for updating. Just adding context in case.
There was a problem hiding this comment.
Gotcha, thanks for double-checking to verify!
What
airbyte-cdkversion and removed dependencies that come packaged with it frompyproject.tomlold-configtoconfigfor consistency