8000
Skip to content

Bmoric/right error for refresh - #22471

Merged
Benoit Moriceau (benmoriceau) merged 6 commits into
masterfrom
bmoric/right-error-for-refresh
Feb 7, 2023
Merged

Bmoric/right error for refresh#22471
Benoit Moriceau (benmoriceau) merged 6 commits into
masterfrom
bmoric/right-error-for-refresh

Conversation

@benmoriceau
@benmoriceau Benoit Moriceau (benmoriceau) commented Feb 7, 2023 •
edited
Loading
Copy link
Copy Markdown
Contributor

What

Set a specific error if the refresh schema activity fails.

This PR set a meaningful error message, in order to avoid having an hard to understand root cause in case of a timeout error.

File Order

  • SyncWorkflowImpl (and test) => Catch all errors and return the right type.
  • SyncOutputProvider => Create the syncoutput with an error.
  • config.yml/failureReason.yml => add a new failure type specific to the refersh_schema. This might need to be in the failure origin instead. Happy to revisit it.

@octavia-squidington-iii Octavia Squidington III (octavia-squidington-iii) added area/api Related to the api area/platform issues related to the platform area/worker Related to worker labels Feb 7, 2023
@benmoriceau
Benoit Moriceau (benmoriceau) temporarily deployed to more-secrets February 7, 2023 09:15 — with GitHub Actions Inactive
@benmoriceau
Benoit Moriceau (benmoriceau) temporarily deployed to more-secrets February 7, 2023 09:15 — with GitHub Actions Inactive
jdpgrailsdev
Jonathan Pearlin (jdpgrailsdev) approved these changes Feb 7, 2023
View reviewed changes
@jdpgrailsdev Jonathan Pearlin (jdpgrailsdev) left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@benmoriceau
Benoit Moriceau (benmoriceau) temporarily deployed to more-secrets February 7, 2023 19:03 — with GitHub Actions Inactive
@benmoriceau
Benoit Moriceau (benmoriceau) temporarily deployed to more-secrets February 7, 2023 19:03 — with GitHub Actions Inactive
@benmoriceau
Benoit Moriceau (benmoriceau) temporarily deployed to more-secrets February 7, 2023 20:53 — with GitHub Actions Inactive
@benmoriceau
Benoit Moriceau (benmoriceau) temporarily deployed to more-secrets February 7, 2023 20:53 — with GitHub Actions Inactive
@benmoriceau
Benoit Moriceau (benmoriceau) temporarily deployed to more-secrets February 7, 2023 21:26 — with GitHub Actions Inactive
@benmoriceau
Benoit Moriceau (benmoriceau) temporarily deployed to more-secrets February 7, 2023 21:26 — with GitHub Actions Inactive
@github-actions
github-actions Bot commented Feb 7, 2023
Copy link
Copy Markdown
Contributor

Airbyte Code Coverage

File Coverage [89.79%] 🍏
SyncOutputProvider.java 95.38% 🍏
SyncWorkflowImpl.java 89.47% 🍏
SyncCheckConnectionFailure.java 87.79% 🍏
Total Project Coverage 24.57% ❌

@benmoriceau
Benoit Moriceau (benmoriceau) deleted the bmoric/right-error-for-refresh branch February 7, 2023 22:16
@github-actions github-actions Bot mentioned this pull request Feb 8, 2023
Closed
Closed
danidelvalle pushed a commit to danidelvalle/airbyte that referenced this pull request Feb 9, 2023
@benmoriceau @danidelvalle-frontiers
Bmoric/right error for refresh (airbytehq#22471)
b04321a 
* Get a better failure reason for the refresh schema error

* Use share empty stats

* Format

* Add missing import

* fix pmd
This was referenced Feb 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesnodgrass Cole Snodgrass (colesnodgrass) Awaiting requested review from colesnodgrass
@gosusnp Jimmy Ma (gosusnp) Awaiting requested review from gosusnp
@malikdiarra Malik Diarra (malikdiarra) Awaiting requested review from malikdiarra
@cgardens Charles (cgardens) Awaiting requested review from cgardens
@alovew Anne (alovew) Awaiting requested review from alovew
1 more reviewer
@jdpgrailsdev Jonathan Pearlin (jdpgrailsdev) jdpgrailsdev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/api Related to the api area/platform issues related to the platform area/worker Related to worker

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@benmoriceau @jdpgrailsdev @octavia-squidington-iii
0