Upgrade GitHub Actions for Node 24 compatibility#853
Upgrade GitHub Actions for Node 24 compatibility#853tonychang04 merged 1 commit intoInsForge:mainfrom
Conversation
Signed-off-by: Salman Muin Kayser Chishti <13schishti@gmail.com>
WalkthroughGitHub Actions dependencies are upgraded across five workflow files. The checkout action is bumped from v4 to v6 in all workflows; the setup-node action is additionally upgraded from v4 to v6 in two workflows. No workflow logic or step sequences are altered. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes with custom instructions.Set the |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/build-image.yml (1)
103-107: Quote shell variables to prevent word splitting (SC2086).The actionlint validation detected shellcheck SC2086 at line 103. While the values are unlikely to contain spaces, quoting the variables follows best practices and silences the warning.
🔧 Proposed fix
run: | # Convert GHCR image name to lowercase (Docker requires lowercase) GHCR_IMAGE=$(echo "${GHCR_IMAGE_RAW}" | tr '[:upper:]' '[:lower:]') # Copy multi-arch image from GHCR to ECR (preserves all platforms) - crane copy ${GHCR_IMAGE}:${VERSION} ${ECR_IMAGE}:${VERSION} + crane copy "${GHCR_IMAGE}:${VERSION}" "${ECR_IMAGE}:${VERSION}"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/build-image.yml around lines 103 - 107, The shell step uses unquoted variables which can cause word-splitting (SC2086); update the assignments and the crane invocation to quote the variables: when creating GHCR_IMAGE use echo "${GHCR_IMAGE_RAW}" | tr ... to build GHCR_IMAGE, and call crane copy with the quoted image refs (e.g. crane copy "${GHCR_IMAGE}:${VERSION}" "${ECR_IMAGE}:${VERSION}") so GHCR_IMAGE, GHCR_IMAGE_RAW, VERSION and ECR_IMAGE are all properly quoted.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/build-image.yml:
- Around line 103-107: The shell step uses unquoted variables which can cause
word-splitting (SC2086); update the assignments and the crane invocation to
quote the variables: when creating GHCR_IMAGE use echo "${GHCR_IMAGE_RAW}" | tr
... to build GHCR_IMAGE, and call crane copy with the quoted image refs (e.g.
crane copy "${GHCR_IMAGE}:${VERSION}" "${ECR_IMAGE}:${VERSION}") so GHCR_IMAGE,
GHCR_IMAGE_RAW, VERSION and ECR_IMAGE are all properly quoted.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 607b4d4d-26a7-4cfc-86a2-99b65038faac
📒 Files selected for processing (5)
.github/workflows/build-image.yml.github/workflows/ci-premerge-check.yml.github/workflows/e2e.yml.github/workflows/lint-and-format.yml.github/workflows/unit-tests.yml
Warning
You may currently be seeing a warning like this in your workflow runs:
The exact actions listed will vary per workflow.
Upgrades GitHub Actions to versions that support Node 24, since Node 20 is reaching EOL in April 2026.
Changes
actions/checkoutv4v6actions/setup-nodev4v6Context
Per GitHub's announcement, Node 20 is being deprecated and runners will default to Node 24 starting June 2nd, 2026.
Release Notes
Release notes for actions/checkout
v6.0.2
What's Changed
Full Changelog: actions/checkout@v6.0.1...v6.0.2
v6.0.1
What's Changed
Full Changelog: actions/checkout@v6...v6.0.1
v6.0.0
What's Changed
Full Changelog: https://github.com/actions/checkout/compare/v5.0.
...truncated
v5.0.1
What's Changed
Full Changelog: actions/checkout@v5...v5.0.1
v4.3.1
What's Changed
Full Changelog: actions/checkout@v4...v4.3.1
Release notes for actions/setup-node
v6.3.0
What's Changed
Enhancements:
devEnginesfield by @susnux in feat(node-version-file): support parsingdevEnginesfield actions/setup-node#1283Dependency updates:
...truncated
v6.2.0
What's Changed
Documentation
...truncated
v6.1.0
What's Changed
Enhancement:
Dependency updates:
...truncated
v6.0.0
What's Changed
Breaking Changes
Dependency Upgrades
...truncated
v5.0.0
What's Changed
Breaking Changes
This update, introduces automatic caching when a valid
packageManagerfield is present in yourpackage.json. This aims to improve workflow performance and make dependency management more seamless.To disable this automatic caching, set
package-manager-cache: false