fastwalk: only check if MSYSTEM is set during MSYS/MSYS2#28
Merged
charlievieth merged 1 commit intomasterfrom Jul 17, 2024
Merged
fastwalk: only check if MSYSTEM is set during MSYS/MSYS2#28charlievieth merged 1 commit intomasterfrom
charlievieth merged 1 commit intomasterfrom
Conversation
f3bb796 to
057acb7
Compare
This changes the MSYS/MSYS2 detection to only check if the MSYSTEM environment variable is set instead of asserting on its value. This is to support other MSYS environments like UCRT64. It also removes the check for Windows Subsystem for Linux (WSL) since it was unreliable and required us to stat and potentially read a file on initialization (which is bad). See: * 87029d9#r144282929 * sharkdp/fd@f875ea9a5
4d53be8 to
3a62e57
Compare
charlievieth
added a commit
to charlievieth/fzf
that referenced
this pull request
Jul 18, 2024
This commit updates github.com/charlievieth/fastwalk to v1.0.7 which improves MSYS detection and adds optional sorting of directory entries. It also updates fzf to use the SortFilesFirst sort mode which improves the output by making it a bit more sorted and grouped by directory previously entries were visited in directory order (which is basically random). PRs Included: * charlievieth/fastwalk#25 * charlievieth/fastwalk#27 * charlievieth/fastwalk#28
charlievieth
added a commit
to charlievieth/fzf
that referenced
this pull request
Jul 18, 2024
This commit updates github.com/charlievieth/fastwalk to v1.0.8 which improves MSYS detection and adds optional sorting of directory entries. It also updates fzf to use the SortFilesFirst sort mode which improves the output by making it a bit more sorted and grouped by directory previously entries were visited in directory order (which is basically random). PRs Included: * charlievieth/fastwalk#25 * charlievieth/fastwalk#27 * charlievieth/fastwalk#28
charlievieth
added a commit
to charlievieth/fzf
that referenced
this pull request
Jul 18, 2024
This commit updates github.com/charlievieth/fastwalk to v1.0.8 which improves MSYS detection and adds optional sorting of directory entries. It also updates fzf to use the SortFilesFirst sort mode which improves the output by making it a bit more sorted and grouped by directory previously entries were visited in directory order (which is basically random). PRs Included: * charlievieth/fastwalk#25 * charlievieth/fastwalk#27 * charlievieth/fastwalk#28
junegunn
pushed a commit
to junegunn/fzf
that referenced
this pull request
Jul 19, 2024
This commit updates github.com/charlievieth/fastwalk to v1.0.8 which improves MSYS detection and adds optional sorting of directory entries. It also updates fzf to use the SortFilesFirst sort mode which improves the output by making it a bit more sorted and grouped by directory previously entries were visited in directory order (which is basically random). PRs Included: * charlievieth/fastwalk#25 * charlievieth/fastwalk#27 * charlievieth/fastwalk#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the MSYS/MSYS2 detection to only check if the MSYSTEM environment variable is set instead of asserting on its value. This is to support other MSYS environments like UCRT64.
See: