8000
Skip to content

ui: improve UX on the entities selector modal - #21903

Merged
cedric-anne merged 4 commits into
glpi-project:11.0/bugfixesfrom
froozeify:update-entities-selector
Nov 17, 2025
Merged

ui: improve UX on the entities selector modal#21903
cedric-anne merged 4 commits into
glpi-project:11.0/bugfixesfrom
froozeify:update-entities-selector

Conversation

@froozeify
@froozeify froozeify commented Nov 12, 2025 •
edited
Loading
Copy link
Copy Markdown
Member

Checklist before requesting a review

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.

Description

This PR was part of #21680

Small UI update to improve UX on the entities selector modal, so user can better see that the arrow down is a button.
I personally searched for a long time before finding I could click on it.

Screenshots (if appropriate):

  • Before
    Screenshot from 2025-10-28 15-51-59
  • After
    Screenshot from 2025-10-28 15-51-32

@cconard96
cconard96 commented Nov 12, 2025 •
edited
Loading
Copy link
Copy Markdown
Member

I don't personally like how it looks with the new styles. I'm also a little concerned there is still user confusion when there is an info message in the selector saying that clicking the down arrows loads the entity and its sub-entities.

orthagh
orthagh reviewed Nov 12, 2025
View reviewed changes
Comment thread templates/layout/parts/profile_selector_form.html.twig Outdated
@froozeify @orthagh
Update templates/layout/parts/profile_selector_form.html.twig
4f949a5 
Co-authored-by: Alexandre Delaunay <delaunay.alexandre@gmail.com>
@froozeify
froozeify commented Nov 12, 2025
Copy link
Copy Markdown
Member Author

I don't personally like how it looks with the new styles. I'm also a little concerned there is still user confusion when there is an info message in the selector saying that clicking the down arrows loads the entity and its sub-entities.

To be honest when I was working on my other PR/issue I took me a long time to understood that I could click on the arrow-down to enable the child selection.

Since I'm fresh to GLPI, I saw that as an UX issue, that's why I proposed a light square around the button so when you quickly open the menu your eye see it better as a button with a possible action.

@cconard96
cconard96 commented Nov 12, 2025
Copy link
Copy Markdown
Member

Since I'm fresh to GLPI, I saw that as an UX issue, that's why I proposed a light square around the button so when you quickly open the menu your eye see it better as a button with a possible action.

Seeing as we needed an info alert to explain the behavior in the first place indicates a UX issue. I'm just not sure if this will completely resolve it. I guess we would need to wait and see if someone is still confused.

With this change, can we remove the alert?

@cedric-anne
cedric-anne commented Nov 13, 2025
Copy link
Copy Markdown
Member

Since I'm fresh to GLPI, I saw that as an UX issue, that's why I proposed a light square around the button so when you quickly open the menu your eye see it better as a button with a possible action.

Seeing as we needed an info alert to explain the behavior in the first place indicates a UX issue. I'm just not sure if this will completely resolve it. I guess we would need to wait and see if someone is still confused.

With this change, can we remove the alert?

Maybe the button tooltip should be improved too. With a button that can be clearly identified and a meaningful tooltip, the alert would be indeed useless.

@orthagh
orthagh commented Nov 13, 2025
Copy link
Copy Markdown
Member

With this change, can we remove the alert?

Clearly yes.

Maybe the button tooltip should be improved too.

Yes also.

@froozeify could you make these changes:

  • remove completely the info alert explaining how to use the mini buttons
  • enhance the tooltip to something like "Select XXXX entity with all its sub entities" (bold style could be a good enhancement, but this could be complex to achieve with tx strings)
  • keep the button style as it is now in the current PR
  • while you are at it, could you add .d-block to the alert recalling the keyboard shortcut and fix the display
image

Maybe we can later review the ux with checkboxes later, but this is not the place nor the time.

@froozeify
froozeify removed the request for review from cedric-anne November 17, 2025 12:45
@cedric-anne cedric-anne added this to the 11.0.3 milestone Nov 17, 2025
@cedric-anne
cedric-anne merged commit 4055eb7 into glpi-project:11.0/bugfixes Nov 17, 2025
8 checks passed
@froozeify
froozeify deleted the update-entities-selector branch November 17, 2025 14:39
@github-actions
github-actions Bot commented Feb 26, 2026
Copy link
Copy Markdown
Contributor

This PR has been is closed and has been automatically locked. Please open a new issue with all requested information for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@orthagh orthagh orthagh left review comments
@trasher trasher trasher approved these changes
@cedric-anne cedric-anne cedric-anne approved these changes
@AdrienClairembault AdrienClairembault AdrienClairembault approved these changes

Assignees

No one assigned

Labels

ui ux

Projects

None yet

Milestone

11.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

@froozeify @cconard96 @cedric-anne @orthagh @trasher @AdrienClairembault
0