Forced Colors Mode WebDriver Emulation - #11823
Conversation
|
Opening for official review given the resolution in #11824 (comment). Thanks @tabatkins for already taking a look. @fantasai feel free to lmk if you have any feedback. In the meantime, I'll reach out to the WebDriver folks to see if they have any thoughts on this change. |
|
Adding @shs96c in comment since I wasn't able to add as a direct reviewer. He is one of the WebDriver spec editors, and said that the change looks good overall, but offered to take a closer look at the content of the change once back from vacation. He also noted that there is a new version of the WebDriver spec:
So in the meantime, I'll look at the Bidi version of the spec and make the necessary updates to move over to that model |
|
An update for reviewers (@tabatkins, @fantasai, @shs96c, @svgeesus), I've updated this PR to be based on the webdriver bidi spec. All PR links in the description have been updated. Based on existing Bidi modules, this seemed to fit nicely into the existing emulation module, which required a draft spec change in w3c/webdriver-bidi#905. I'll inform the bidi spec owners of these PRs, as well, for review. |
Forced Colors Mode is difficult to test via WPT because it is dependent on OS state (Window High Contrast) to trigger the feature to light up.
This change builds on a drafted webdriver-bidi emulation command (see w3c/webdriver-bidi#905) to define a new forced colors emulation (https://alisonmaher.github.io/alisonmaher/css-color-adjust-1/Overview.html#emualte-forced-colors-mode) that keeps track of the current forced colors mode emulation state.
The change also updates the forced colors mode algorithm (https://alisonmaher.github.io/alisonmaher/css-color-adjust-1/Overview.html#forced) to inform the UA what to do when the forced colors mode emulation state is either
"light"or"dark".CSSWG resolution for this change: #11824 (comment)
This change also fixes a few unrelated tabbing issues in the CSS Color Adjust 1 spec.